← Back to UN country layer · Country index

Add guardrail test: release_review cannot pass on tiny seeded population artifacts

done synth-modeler

Task metadata

idt_1aacf742
titleAdd guardrail test: release_review cannot pass on tiny seeded population artifacts
assigneesynth-modeler
statusdone
tenantsynthestat
priority85
workspace_kinddir
workspace_path/home/synthestat
created_bysynth-reviewer
created_at2026-05-19 22:05:22 CEST
started_at2026-05-19 23:01:59 CEST
completed_at2026-05-19 23:19:13 CEST

Latest summary

Accepted after independent reviewer t_ad3f39b7 PASS. release_review now blocks tiny/seeded population artifacts from pass-like national decisions unless explicitly seeded/internal-only; focused test suite passed (12 tests). No source/model follow-up required for this guardrail.

Body

Parent reviewer sweep t_1aeadf3a found pass_with_warnings release decisions for DK/FI/NL/NO/SE despite top-level population_synthesis artifacts with only 5-9 persons. Add a generation-time/test guard that fails or blocks pass-like release decisions when population_synthesis.person_count is below a country-scale threshold or notes identify a seeded slice, unless the decision is explicitly seeded/internal-only. Evidence report: /home/synthestat/output/reviews/national_scale_claims_sanity_sweep_2026-05-19.md

Parents

[
  "t_1aeadf3a"
]

Children

[]

Runs

IDProfileStatusOutcomeStartedEndedSummary/error
210synth-modelerblockedblocked2026-05-19 23:01:59 CEST2026-05-19 23:10:11 CESTreview-required: release_review now blocks tiny/seeded population artifacts from pass-like national decisions; 12/12 focused tests pass, needs human review before marking done.
240synth-modelercompletedcompleted2026-05-19 23:19:13 CEST2026-05-19 23:19:13 CESTAccepted after independent reviewer t_ad3f39b7 PASS. release_review now blocks tiny/seeded population artifacts from pass-like national decisions unless explicitly seeded/internal-only; focused test suite passed (12 tests). No source/model follow-up required for this guardrail.

Events

TimeKindPayload
2026-05-19 22:05:22 CESTcreated{ "assignee": "synth-coder", "status": "todo", "parents": [ "t_1aeadf3a" ], "tenant": "synthestat", "skills": null }
2026-05-19 22:05:49 CESTpromotednull
2026-05-19 22:09:02 CESTassigned{ "assignee": "synth-modeler" }
2026-05-19 23:01:59 CESTclaimed{ "lock": "vmi3188806:1759264", "expires": 1779225419, "run_id": 210 }
2026-05-19 23:01:59 CESTspawned{ "pid": 1759269 }
2026-05-19 23:10:06 CESTcommented{ "author": "synth-modeler", "len": 1455 }
2026-05-19 23:10:11 CESTblocked{ "reason": "review-required: release_review now blocks tiny/seeded population artifacts from pass-like national decisions; 12/12 focused tests pass, needs human review before marking done." }
2026-05-19 23:19:13 CESTcompleted{ "result_len": 0, "summary": "Accepted after independent reviewer t_ad3f39b7 PASS. release_review now blocks tiny/seeded population artifacts from pass-like national decisions unless explicitly seeded/internal-only; focused test suite passed (12 tests). No source/model follow-up required for this guardrail." }

Comments

2026-05-19 23:10:06 CEST · synth-modeler
review-required handoff:
{
  "changed_files": [
    "synthestat/generate/country_release_review.py",
    "tests/test_release_review.py",
    "workspace/manager_handoffs/modeller/2026-05-19_2308_build_status.md",
    "workspace/manager_handoffs/modeller/2026-05-19_2308_missing_requirements.md",
    "workspace/manager_handoffs/modeller/latest.md",
    "workspace/manager_handoffs/manager_updates.md"
  ],
  "tests_run": [
    "pytest tests/test_release_review.py -q -> 12 passed"
  ],
  "behavior": [
    "release_review generation computes population_synthesis.release_scope and release_scope_reason",
    "tiny population_synthesis.person_count (<1000) or seeded-slice notes block national-candidate/pass-like release decisions",
    "explicit seeded/internal-only metadata (for example release_scope=seeded_internal_only) remains allowed as a non-national lane"
  ],
  "notes": [
    "The worktree already had uncommitted edits in synthestat/generate/country_release_review.py and tests/test_release_review.py before this run; I preserved and built on them.",
    "No country population bundles or top-level output/<CC>/release_review.json files were regenerated."
  ],
  "handoffs": [
    "/home/synthestat/workspace/manager_handoffs/modeller/2026-05-19_2308_build_status.md",
    "/home/synthestat/workspace/manager_handoffs/modeller/2026-05-19_2308_missing_requirements.md",
    "/home/synthestat/workspace/manager_handoffs/modeller/latest.md"
  ]
}